Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean base controller code #2046

Merged
merged 5 commits into from
Aug 13, 2019
Merged

clean base controller code #2046

merged 5 commits into from
Aug 13, 2019

Conversation

behnampro
Copy link
Contributor

Each pull request should address a single issue, and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345
  • Unsolicited PRs will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

MGatner
MGatner approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fine PR.

lonnieezell
lonnieezell reviewed Aug 13, 2019
View reviewed changes
app/Controllers/BaseController.php
<?php namespace App\Controllers;
<?php

namespace App\Controllers;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer this on the first line, but I'm not going to reject a PR because of it :)

@lonnieezell
Copy link
Member

Please use GPG signed requests next time. How-to in the contributor docs.

@lonnieezell lonnieezell merged commit fee814b into codeigniter4:develop Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell left review comments

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behnampro @lonnieezell @MGatner